[S] Change in coreboot[main]: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, V Sowmya.
Poornima Tom has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/83077?usp=email )
Change subject: mb/google/brya/var/nivviks: Enable PCIe Wifi Gpios based on fw_config ......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83077/comment/b20823ca_0d8ffe2f?usp... : PS6, Line 9: cofig
config
Done
File src/mainboard/google/brya/variants/nivviks/fw_config.c:
https://review.coreboot.org/c/coreboot/+/83077/comment/fcedb590_24e69b53?usp... : PS6, Line 103: PAD_CFG_GPO
do we need to lock this as well ?
Ideally, i think, locking of GPIO becomes relevant, when it is some thing like Write protect signal or something. Also , if we lock this PERST0 signal, then later, if kernel wants to reset the module, this locking will limit it right? Also, i looked in the Gale Peak2 EPS doc, but didnot find anything which says that we must lock this reset signal.
https://review.coreboot.org/c/coreboot/+/83077/comment/3780e724_6438af8f?usp... : PS6, Line 129: WIFI_TYPE
this is wrong, please fix this problem ? […]
Oh, My bad! I have 2 seperate repos , which i use for upstreaming and testing. Done with correction. :) Thanks.
-
Poornima Tom (Code Review)