Attention is currently required from: Angel Pons, Christian Walter, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Angel Pons, Christian Walter, Jakub Czapiga, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Lean Sheng Tan, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84039?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed: Code-Review+1 by Angel Pons, Code-Review+1 by Nico Huber, Code-Review+1 by Shuo Liu, Verified+1 by build bot (Jenkins)
Change subject: cbmem.h: Change return type of cbmem_get_region ......................................................................
cbmem.h: Change return type of cbmem_get_region
The underlying IMD function already returns an integer which indicates success or failure.
This removes the need to have initialized variables that need to be checked for NULL later. In some cases this actually adds the appropriate check for returned values.
Dying is appropriate if cbmem is not found as it is essential to the bootflow.
Change-Id: Ib3e09a75380faf9f533601368993261f042422ef Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/postcar_loader.c M src/include/cbmem.h M src/lib/fit_payload.c M src/lib/imd_cbmem.c M src/security/memory/memory_clear.c M src/soc/intel/xeon_sp/memmap.c M tests/lib/Makefile.mk 7 files changed, 23 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/84039/8
-
Arthur Heymans (Code Review)