Change in coreboot[master]: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id - coreboot-gerrit

14 Apr 2022


      Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63641 )
Change subject: drivers/usb/pci_xhci: Add Sabrina xhci pci devce id
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/drivers/usb/pci_xhci/pci_xhci.c:
https://review.coreboot.org/c/coreboot/+/63641/comment/c4c73f90_174cc0fc 
PS1, Line 262: PCI_DID_AMD_FAM17H_MODELA0H_XHCI2
Ugh, I really hate maintaining this list. This driver is generic and will work for any PCI xCHI compliant controller. I wonder if it would be more clear to have this as a chip driver in the device tree?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63641
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3
Gerrit-Change-Number: 63641
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 14 Apr 2022 19:52:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment