Attention is currently required from: Kyösti Mälkki.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55700 )
Change subject: cpu/x86/lapic: Do not set read-only bits in LVTx
......................................................................
Patch Set 8:
(1 comment)
File src/cpu/x86/lapic/lapic.c:
https://review.coreboot.org/c/coreboot/+/55700/comment/b11bacfd_85a87a04
PS8, Line 55: LAPIC_LVT_REMOTE_IRR |
: LAPIC_INPUT_POLARITY | LAPIC_SEND_PENDING
Should they be removed here as well?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bcb9eb990debe169340a0bfe662158b62a8f4dc
Gerrit-Change-Number: 55700
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 14 Oct 2021 11:52:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment