Attention is currently required from: Dinesh Gehlot, Eric Lai, Felix Held, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Rishika Raj, Roger Wang, Shou-Chieh Hsu.
Subrata Banik has posted comments on this change by Roger Wang. ( https://review.coreboot.org/c/coreboot/+/83792?usp=email )
Change subject: mb/google/nissa/var/sundance: Adjust WWAN GPIO sequence
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Hi Subrata,
Regarding the WWAN seq, it appears that setting it up RST in the bootblock may not be necessary. If we configure it from the bootblock, the sequence will be triggered at the same time.
The customer hopes that we can leave some buffer for EN to RST. Thanks
thanks for the explanation. could you please update the commit msg with the same explanation.
```
This patch removes WWAN configuration from the bootblock because it appears that setting it up in the bootblock may not be necessary. If we configure it from the bootblock, the sequence will be triggered at the same time. The customer would like us to leave some buffer for EN to RST.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83792?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2c0e789c0bec293f4bca711e53644d62f4f83551
Gerrit-Change-Number: 83792
Gerrit-PatchSet: 2
Gerrit-Owner: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Roger Wang
roger2.wang@lcfc.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 12 Aug 2024 06:41:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Roger Wang
roger2.wang@lcfc.corp-partner.google.com