Change in coreboot[master]: soc/mediatek/mt8186: set pin drive strength to 8mA for NOR - coreboot-gerrit

7 Mar 2022


      Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62472 )
Change subject: soc/mediatek/mt8186: set pin drive strength to 8mA for NOR
......................................................................
Patch Set 11: Code-Review+1
(1 comment)
File src/soc/mediatek/mt8186/spi.c:
https://review.coreboot.org/c/coreboot/+/62472/comment/67d61ea0_2b36fdc8 
PS11, Line 154: NOR_PIN_DRIVE_STRENGTH
I'd drop this `NOR_PIN_DRIVE_STRENGTH` macro and use `GPIO_DRV_8_MA` directly
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/62472
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b6e37b0f7d4207ea35f11394d25ad1e096ac01a
Gerrit-Change-Number: 62472
Gerrit-PatchSet: 11
Gerrit-Owner: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marina Michelle marinamichelle100@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 07 Mar 2022 16:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment