Attention is currently required from: Name of user not set #1003506, Martin Roth, Angel Pons, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 1:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52594/comment/7d297502_5f0305ff PS1, Line 9: I'm new to coreboot. Welcome!
https://review.coreboot.org/c/coreboot/+/52594/comment/f1a0f512_24559f43 PS1, Line 15: * find out how to tell the OS that this board has no video output. Any issue with that?
In case of you just want to disable it: It seems that the specific FSP option is not hooked up to our SoC code, at least I wasn't able to find that `Igd` option in the code. https://github.com/intel/FSP/blob/master/ApolloLakeFspBinPkg/Include/FspmUpd....
You can do that manually in your romstage.c file.
File src/mainboard/synology/ds918plus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52594/comment/9d4aa316_e7474146 PS1, Line 12: lpc_configure_pads(); I can't find it anywhere and it's breaking the compiling. Is it needed?
File src/mainboard/synology/ds918plus/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/52594/comment/e16be50e_ce4ca189 PS1, Line 14: /* global NVS and variables */ Does not really add more value, remove it. Same below.
https://review.coreboot.org/c/coreboot/+/52594/comment/49161a85_d00ae1a0 PS1, Line 25: #include <soc/intel/apollolake/acpi/pch_hda.asl> Might not be needed, if audio controller is unused.
https://review.coreboot.org/c/coreboot/+/52594/comment/ec7e38d5_03bf93e3 PS1, Line 29: #include <southbridge/intel/common/acpi/sleepstates.asl> : } Maybe move it to the other includes. Looks cleaner this way:)
File src/mainboard/synology/ds918plus/mainboard.c:
PS1: If you don't mind, please have a look at clevo/cml-u/variants/l140cu on how we do GPIO configuration there. In general, we moved the call for `gpio_configure_pads()` into the gpio.c file. This way, you don't have to do that overhead with returning the array and array size first.
Same with bootblock.c