Change in coreboot[master]: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly
Peter Lemenkov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38433 )
Change subject: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly ......................................................................
mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly
ONBOARD_VGA_IS_PRIMARY is selected if board selects DRIVERS_LENOVO_HYBRID_GRAPHICS.
See commit 35abe73e with Change-Id: I6594fbb957c9a8135fe670d38b5755adf29d2dff ("mb/lenovo/t430: Fix Dual Graphics").
Change-Id: I39687e5cd34979fd4318978f5aa46ac6cdf721e8 Signed-off-by: Peter Lemenkov lemenkov@gmail.com --- M src/mainboard/lenovo/t410/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/38433/1
diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index f97a093..5d60565 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -59,10 +59,6 @@ int default 8
-config ONBOARD_VGA_IS_PRIMARY - bool - default y - config DRAM_RESET_GATE_GPIO int default 10
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38433 )
Change subject: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG@15 PS1, Line 15: Please explicitly state, what currently does not work. Or is it just a cosmetic fix?
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38433 )
Change subject: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG@15 PS1, Line 15:
Please explicitly state, what currently does not work. […]
It's just a cosmetic fix. There is no need to select it since it was selected as a dependency to DRIVERS_LENOVO_HYBRID_GRAPHICS
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38433 )
Change subject: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38433/1//COMMIT_MSG@15 PS1, Line 15:
It's just a cosmetic fix. […]
Specifically, it's dropping redundant "select" Kconfig statements
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38433 )
Change subject: mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly ......................................................................
mb/lenovo/t410/Kconfig: Don't select ONBOARD_VGA_IS_PRIMARY explicitly
ONBOARD_VGA_IS_PRIMARY is selected if board selects DRIVERS_LENOVO_HYBRID_GRAPHICS.
See commit 35abe73e with Change-Id: I6594fbb957c9a8135fe670d38b5755adf29d2dff ("mb/lenovo/t430: Fix Dual Graphics").
Change-Id: I39687e5cd34979fd4318978f5aa46ac6cdf721e8 Signed-off-by: Peter Lemenkov lemenkov@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38433 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/lenovo/t410/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/t410/Kconfig b/src/mainboard/lenovo/t410/Kconfig index f97a093..5d60565 100644 --- a/src/mainboard/lenovo/t410/Kconfig +++ b/src/mainboard/lenovo/t410/Kconfig @@ -59,10 +59,6 @@ int default 8
-config ONBOARD_VGA_IS_PRIMARY - bool - default y - config DRAM_RESET_GATE_GPIO int default 10
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)