Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/Kconfig:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 10: 3
Prefer this stays 3, since all the current platforms have 3 and as said earlier this is not going to […]
Then, maybe its better to just have this as a macro if you are not expecting it to change?
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 781: partition_id != BP1 && partition_id != BP2
The BP contents can be basically categorized as below. […]
Those details should be captured in comments. Also, can you please point me to a spec where these details are covered?
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 153: enum
There are more places we will use these named BPs, for example in set_net_boot_partition, caller has […]
Can those instances use something like BP(1) and BP(2)?
-
Furquan Shaikh (Code Review)