Mete Balci has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31821
Change subject: util/chromeos: Add unzip as a dependency ......................................................................
util/chromeos: Add unzip as a dependency
unzip might not be installed by default, so it is added as a dependency in crosfirmware script.
Change-Id: I420067b3e8ed26e6a7dccb863aae1272a3c7acbc Signed-off-by: Mete Balci metebalci@gmail.com --- M util/chromeos/crosfirmware.sh 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/31821/1
diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 9d2ca84..0564106 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -37,6 +37,7 @@ exit_if_uninstalled "debugfs" "e2fsprogs" exit_if_uninstalled "parted" "parted" exit_if_uninstalled "curl" "curl" + exit_if_uninstalled "unzip" "unzip" }
get_inventory()
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31821 )
Change subject: util/chromeos: Add unzip as a dependency ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/31821 )
Change subject: util/chromeos: Add unzip as a dependency ......................................................................
util/chromeos: Add unzip as a dependency
unzip might not be installed by default, so it is added as a dependency in crosfirmware script.
Change-Id: I420067b3e8ed26e6a7dccb863aae1272a3c7acbc Signed-off-by: Mete Balci metebalci@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/31821 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/chromeos/crosfirmware.sh 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index dc33fac..5fec96b 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -37,6 +37,7 @@ exit_if_uninstalled "debugfs" "e2fsprogs" exit_if_uninstalled "parted" "parted" exit_if_uninstalled "curl" "curl" + exit_if_uninstalled "unzip" "unzip" }
get_inventory()
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31821 )
Change subject: util/chromeos: Add unzip as a dependency ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/1076 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1075 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/1074
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Mete Balci (Code Review)
-
Patrick Georgi (Code Review)