Attention is currently required from: Alexander Couzens, Paul Menzel, Pratikkumar V Prajapati.
Felix Held has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/75214?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: inteltool: improve support for Elkhart Lake
......................................................................
Patch Set 7:
(1 comment)
File util/inteltool/inteltool.h:
https://review.coreboot.org/c/coreboot/+/75214/comment/34f9ad9c_4235eb1f?usp... :
PS7, Line 513:
i wonder why this empty line and the one a few lines below are added here; probably best to remove those two
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75214?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida852f3c991cdd036d9c282f9cabceb23c765e25
Gerrit-Change-Number: 75214
Gerrit-PatchSet: 7
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Comment-Date: Tue, 17 Sep 2024 13:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No