Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43884 )
Change subject: mb/google/glados/var/caroline: Relocate devicetree FSP settings ......................................................................
mb/google/glados/var/caroline: Relocate devicetree FSP settings
Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.
Change-Id: I52af81e1f41bdb96c35c47ce00844bba4c935e1a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/variants/caroline/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43884/1
diff --git a/src/mainboard/google/glados/variants/caroline/overridetree.cb b/src/mainboard/google/glados/variants/caroline/overridetree.cb index 7bee2e2..8078069 100644 --- a/src/mainboard/google/glados/variants/caroline/overridetree.cb +++ b/src/mainboard/google/glados/variants/caroline/overridetree.cb @@ -1,7 +1,5 @@ chip soc/intel/skylake
- register "ScsSdCardEnabled" = "2" - register "PmConfigSlpS4MinAssert" = "1" # 1s register "PmConfigSlpSusMinAssert" = "1" # 500ms
@@ -88,6 +86,8 @@ device i2c 35 on end end end # I2C #4 - device pci 1e.6 on end # SDCard + device pci 1e.6 on # SDCard + register "ScsSdCardEnabled" = "2" + end end end
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43884
to look at the new patch set (#2).
Change subject: mb/google/glados/var/caroline: Relocate devicetree settings ......................................................................
mb/google/glados/var/caroline: Relocate devicetree settings
Tested with BUILD_TIMELESS=1, its coreboot.rom does not change.
Change-Id: I52af81e1f41bdb96c35c47ce00844bba4c935e1a Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/glados/variants/caroline/overridetree.cb 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/43884/2
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43884 )
Change subject: mb/google/glados/var/caroline: Relocate devicetree settings ......................................................................
Abandoned