[S] Change in coreboot[main]: vc/google/chromeos: Add configurable compression for logo file in cbfs - coreboot-gerrit

17 Jul 2024


      Attention is currently required from: Ashish Kumar Mishra, Julius Werner, Paul Menzel, Shelley Chen, Subrata Banik.
Karthik Ramasubramanian has posted comments on this change by Ashish Kumar Mishra. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83420/comment/23322dbd_1f06dc37?usp... :
PS5, Line 15: ~760ms
This is too big of savings - almost 1 second. Definitely LZMA decompression or loading an uncompressed file does not take that long. Can you please confirm?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83420?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57fbd0d3a39eaba3fb9d61e7a3fb5eeb44e3a839
Gerrit-Change-Number: 83420
Gerrit-PatchSet: 5
Gerrit-Owner: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Attention: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 17 Jul 2024 21:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No