Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35402 )
Change subject: soc/intel/common/block/cse: Add boot partition related APIs ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 177: addr
I believe you mean "CSE region start"?
We mean starting offset of the partition within CSE region.
https://review.coreboot.org/c/coreboot/+/35402/12/src/soc/intel/common/block... PS12, Line 179: CSE region addr
same here.
We mean end offset of the partition within CSE region.
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 143: #define RO_BP1 0 : #define RW_BP2 1 : #define RW_BP3 2
Done
Done
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 175: mkhi_hdr
will be done as part of https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/35402/6/src/soc/intel/common/block/... PS6, Line 215: /* Sets CSE's next boot partition to boot */
what are the return values? What are the valid values for input parameter?
Done
-
Sridhar Siricilla (Code Review)