Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Subrata Banik.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56651 )
Change subject: cpu/x86: Rename X86_AMD_INIT_SIPI to X86_INIT_SIPI
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/56651/comment/ac660cbf_a99325d1
PS1, Line 177: newer AMD, Intel platforms don't need the 10ms wait between INIT and SIPI,
since this is a kconfig help text, the text should probably be reflowed to fit within 80 chars per line.
also maybe "AMD and Intel" instead of "AMD, Intel"?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a4e6a8b1edc6e8ba43597259bd8b2de697e4e62
Gerrit-Change-Number: 56651
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 28 Jul 2021 12:40:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment