Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
util/lint: Capitalise lint descriptions
Most test descriptions are capitalised already. Follow suit.
Change-Id: I756331323a39643244c4adea4c440f305424d6d1 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M util/lint/lint-008-kconfig M util/lint/lint-stable-008-kconfig M util/lint/lint-stable-009-old-licenses 3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/46321/1
diff --git a/util/lint/lint-008-kconfig b/util/lint/lint-008-kconfig index 1adb68f..31aba55 100755 --- a/util/lint/lint-008-kconfig +++ b/util/lint/lint-008-kconfig @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: check Kconfig files for warnings and errors +# DESCR: Check Kconfig files for warnings and errors
LC_ALL=C export LC_ALL
diff --git a/util/lint/lint-stable-008-kconfig b/util/lint/lint-stable-008-kconfig index 79e2a86..3b204fb 100755 --- a/util/lint/lint-stable-008-kconfig +++ b/util/lint/lint-stable-008-kconfig @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: check Kconfig files for errors +# DESCR: Check Kconfig files for errors
LC_ALL=C export LC_ALL
diff --git a/util/lint/lint-stable-009-old-licenses b/util/lint/lint-stable-009-old-licenses index f5c1f41..d2aff3a 100755 --- a/util/lint/lint-stable-009-old-licenses +++ b/util/lint/lint-stable-009-old-licenses @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: verify that files don't have the old style header +# DESCR: Verify that files don't have the old style header
# regex list of files and directories to exclude from the search HEADER_EXCLUDED="\
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 2: Code-Review+1
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 2: Code-Review+2
meh, why compare the capitalization in the first place? I can understand the urge to align once noticed, but why look for such things? :-P
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 2:
Patch Set 2: Code-Review+2
meh, why compare the capitalization in the first place? I can understand the urge to align once noticed, but why look for such things? :-P
I didn't look for it, the pre-commit hook I have runs these lints automatically and I see the mismatch every time I run `git commit`.
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
util/lint: Capitalise lint descriptions
Most test descriptions are capitalised already. Follow suit.
Change-Id: I756331323a39643244c4adea4c440f305424d6d1 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46321 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Nico Huber nico.h@gmx.de --- M util/lint/lint-008-kconfig M util/lint/lint-stable-008-kconfig M util/lint/lint-stable-009-old-licenses 3 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, but someone else must approve
diff --git a/util/lint/lint-008-kconfig b/util/lint/lint-008-kconfig index 1adb68f..31aba55 100755 --- a/util/lint/lint-008-kconfig +++ b/util/lint/lint-008-kconfig @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: check Kconfig files for warnings and errors +# DESCR: Check Kconfig files for warnings and errors
LC_ALL=C export LC_ALL
diff --git a/util/lint/lint-stable-008-kconfig b/util/lint/lint-stable-008-kconfig index 79e2a86..3b204fb 100755 --- a/util/lint/lint-stable-008-kconfig +++ b/util/lint/lint-stable-008-kconfig @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: check Kconfig files for errors +# DESCR: Check Kconfig files for errors
LC_ALL=C export LC_ALL
diff --git a/util/lint/lint-stable-009-old-licenses b/util/lint/lint-stable-009-old-licenses index f5c1f41..d2aff3a 100755 --- a/util/lint/lint-stable-009-old-licenses +++ b/util/lint/lint-stable-009-old-licenses @@ -2,7 +2,7 @@ # # SPDX-License-Identifier: GPL-2.0-only
-# DESCR: verify that files don't have the old style header +# DESCR: Verify that files don't have the old style header
# regex list of files and directories to exclude from the search HEADER_EXCLUDED="\
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 5/1/6 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/23093 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/23092 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/23091 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/23090 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/23088 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/23087
Please note: This test is under development and might not be accurate at all!
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46321 )
Change subject: util/lint: Capitalise lint descriptions ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/2/6 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/23689 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/23092 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/23091 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/23090 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/23088 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/23087
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Matt DeVillier (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)