Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22200 )
Change subject: nb/intel/sandybridge/raminit: Add extended memtest ......................................................................
Patch Set 4:
(1 comment)
We could do somethink like this; if quick_ram_check() fails run the more thorough check in verbose mode. If necessary to save space, this could be behind config DEBUG_RAM_SETUP.
https://review.coreboot.org/#/c/22200/4/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit.c:
https://review.coreboot.org/#/c/22200/4/src/northbridge/intel/sandybridge/ra... PS4, Line 461: ram_check(basek << 10, (basek + (1 << 10)) << 10); That second argument has been ignored for ages now...
To have generic primitive memtest is second reason to have common API to get TOLM/TOM (or TOM / TOM2 as AMD calls them).
You might want to call primitive_memtest() to actually write the entire range.