Attention is currently required from: Martin L Roth, Benjamin Doron, Stefan Reinauer, Paul Menzel, Lean Sheng Tan.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74336 )
Change subject: payloads/edk2: Remove ABOVE_4G_MEMORY option
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74336/comment/f935e449_9f415094
PS1, Line 9: as since
One of the two? Or the comma before *since*?
Done
https://review.coreboot.org/c/coreboot/+/74336/comment/807cfe8b_c1d8161c
PS1, Line 9: commit
coreboot commit?
Done
https://review.coreboot.org/c/coreboot/+/74336/comment/d036dc0e_a653fd4d
PS1, Line 9: Remove the ABOVE_4G_MEMORY option as since, commit
: 59ca9605c39a45740de1fb64ea5b8dbd02f4724e, it no
: longer exists.
Please make use of 72 characters per line.
Done
Patchset:
PS2:
I think all addressed..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74336
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d5ee79ef3f7ecfcd1463c612aad2e3d629df22a
Gerrit-Change-Number: 74336
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 13:35:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment