Attention is currently required from: Cliff Huang, Hannah Williams, Jérémy Compostella, Li1 Feng, Pranava Y N, Subrata Banik, Tanu Malhotra.
Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/84739?usp=email )
Change subject: mb/google/fatcat: support ISH
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84739/comment/7facb11e_30e2e3a7?usp... :
PS2, Line 12: TEST=verified ISH on fatcat
Any detail on how it was verified ?
Done
https://review.coreboot.org/c/coreboot/+/84739/comment/2b7343db_83515f4c?usp... :
PS2, Line 14: Signed-off-by: Bora Guvendik bora.guvendik@intel.corp-partner.google.com
shouldn't you be using you intel. […]
yes, thx
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84739/comment/6538e9e1_1b6b442b?usp... :
PS2, Line 170: /* GPP_D07: ISH_SPI_MISO_SNSR_HDR */
Since we change to ISH UART, these two PADs are no longer used and needs to be set to _NC.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84739?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b6eb39fe7b07fcabc255d66df4aa0aa2865df79
Gerrit-Change-Number: 84739
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Li1 Feng
li1.feng@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 30 Oct 2024 00:55:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com