Paul Fagerburg has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42026 )
Change subject: util/mb/google: add templates for puff boards ......................................................................
util/mb/google: add templates for puff boards
Add template directory for the Puff reference board.
BUG=b:157701044 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ic81c663b92eeb1d39c2b425d331eb16812f58b7d --- A util/mainboard/google/puff/template/Makefile.inc A util/mainboard/google/puff/template/include/variant/acpi/dptf.asl A util/mainboard/google/puff/template/include/variant/ec.h A util/mainboard/google/puff/template/include/variant/gpio.h A util/mainboard/google/puff/template/overridetree.cb 5 files changed, 29 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/42026/1
diff --git a/util/mainboard/google/puff/template/Makefile.inc b/util/mainboard/google/puff/template/Makefile.inc new file mode 100644 index 0000000..61b23ed --- /dev/null +++ b/util/mainboard/google/puff/template/Makefile.inc @@ -0,0 +1,4 @@ +## +## SPDX-License-Identifier: GPL-2.0-only + +SPD_SOURCES = diff --git a/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl b/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..fd3b5cf --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/acpi/dptf.asl> diff --git a/util/mainboard/google/puff/template/include/variant/ec.h b/util/mainboard/google/puff/template/include/variant/ec.h new file mode 100644 index 0000000..ce6fbfe --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef VARIANT_EC_H +#define VARIANT_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/puff/template/include/variant/gpio.h b/util/mainboard/google/puff/template/include/variant/gpio.h new file mode 100644 index 0000000..79a1410 --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/util/mainboard/google/puff/template/overridetree.cb b/util/mainboard/google/puff/template/overridetree.cb new file mode 100644 index 0000000..abbcaaa --- /dev/null +++ b/util/mainboard/google/puff/template/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/cannonlake + + device domain 0 on + end + +end
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42026 )
Change subject: util/mb/google: add templates for puff boards ......................................................................
Patch Set 1: Code-Review+2
Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42026 )
Change subject: util/mb/google: add templates for puff boards ......................................................................
util/mb/google: add templates for puff boards
Add template directory for the Puff reference board.
BUG=b:157701044 BRANCH=None TEST=N/A
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: Ic81c663b92eeb1d39c2b425d331eb16812f58b7d Reviewed-on: https://review.coreboot.org/c/coreboot/+/42026 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com --- A util/mainboard/google/puff/template/Makefile.inc A util/mainboard/google/puff/template/include/variant/acpi/dptf.asl A util/mainboard/google/puff/template/include/variant/ec.h A util/mainboard/google/puff/template/include/variant/gpio.h A util/mainboard/google/puff/template/overridetree.cb 5 files changed, 29 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Sam McNally: Looks good to me, approved
diff --git a/util/mainboard/google/puff/template/Makefile.inc b/util/mainboard/google/puff/template/Makefile.inc new file mode 100644 index 0000000..61b23ed --- /dev/null +++ b/util/mainboard/google/puff/template/Makefile.inc @@ -0,0 +1,4 @@ +## +## SPDX-License-Identifier: GPL-2.0-only + +SPD_SOURCES = diff --git a/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl b/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl new file mode 100644 index 0000000..fd3b5cf --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/acpi/dptf.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <baseboard/acpi/dptf.asl> diff --git a/util/mainboard/google/puff/template/include/variant/ec.h b/util/mainboard/google/puff/template/include/variant/ec.h new file mode 100644 index 0000000..ce6fbfe --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef VARIANT_EC_H +#define VARIANT_EC_H + +#include <baseboard/ec.h> + +#endif diff --git a/util/mainboard/google/puff/template/include/variant/gpio.h b/util/mainboard/google/puff/template/include/variant/gpio.h new file mode 100644 index 0000000..79a1410 --- /dev/null +++ b/util/mainboard/google/puff/template/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/util/mainboard/google/puff/template/overridetree.cb b/util/mainboard/google/puff/template/overridetree.cb new file mode 100644 index 0000000..abbcaaa --- /dev/null +++ b/util/mainboard/google/puff/template/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/cannonlake + + device domain 0 on + end + +end
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42026 )
Change subject: util/mb/google: add templates for puff boards ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4857 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4856 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4855 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4854
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Paul Fagerburg (Code Review)
-
Sam McNally (Code Review)