Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ... - coreboot-gerrit

6 Nov 2021


      Attention is currently required from: Patrick Rudolph, Angel Pons, Julius Werner, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )
Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................
Patch Set 22:
(1 comment)
File src/arch/x86/bootblock.ld:
https://review.coreboot.org/c/coreboot/+/51671/comment/5cafc570_ef2cec11 
PS22, Line 57: _ID_SECTION_END - _ECFW_PTR
...
It should not happen, since _ID_SECTION_END is 0xffffff80 at minimum, and _ECFW_PTR is fixed at CONF […]
It can only happen when someone messes up the code.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51671
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f0de0c4d7283e630242fbe84a46e0547783c49e
Gerrit-Change-Number: 51671
Gerrit-PatchSet: 22
Gerrit-Owner: Bill XIE persmule@hardenedlinux.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Sat, 06 Nov 2021 06:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE persmule@hardenedlinux.org
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment