Attention is currently required from: Paul Menzel. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58187 )
Change subject: purism/librem_bdw: add support for ACPI brightness controls ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58187/comment/adbc9179_3c960598 PS1, Line 10: Windows
Which version?
it honestly doesn't matter, Windows + UEFI = ACPI needed for LCD backlight controls with Intel iGPU. But I'll edit the commit msg
https://review.coreboot.org/c/coreboot/+/58187/comment/53e5a918_cec95bca PS1, Line 11:
The i915 kernel driver in Linux exposes its own brightness control devicec, so I'm pretty sure the a […]
yes, ACPI brightness controls are not needed under Linux. This just brings the librem_bdw boards up to par with librem_skl and librem_cnl - not sure why it wasn't done at the same time