Nicolas Boichat has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
mb/google/kukui: Setup display rotation
Add orientation field to all kukui derivatives.
BUG=b:132049716 TEST=Boot krane, see that FW screen is orientation properly.
Change-Id: I1c56a069c008d760780bd185303d16cc8d960ca9 --- M 3rdparty/blobs M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel.h M src/mainboard/google/kukui/panel_jacuzzi.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 6 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34733/1
diff --git a/3rdparty/blobs b/3rdparty/blobs index 9da6d88..90c097f 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 9da6d88a2b0f553b724e70d80a78d7e78f074f5b +Subproject commit 90c097f030cc7ede5671832889c2d18386781840 diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 9c64a69..2362899 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -135,6 +135,7 @@ } mtk_ddp_mode_set(edid); set_vbe_mode_info_valid(edid, 0); + set_vbe_panel_orientation(panel->orientation); return true; }
diff --git a/src/mainboard/google/kukui/panel.h b/src/mainboard/google/kukui/panel.h index 26445e5..02edf34 100644 --- a/src/mainboard/google/kukui/panel.h +++ b/src/mainboard/google/kukui/panel.h @@ -23,6 +23,7 @@ const char *name; /* human readable name */ void (*power_on)(void); /* Callback to turn on panel */ struct edid edid; /* edid info of this panel */ + enum lb_panel_orientation orientation; /* panel orientation */ struct lcm_init_table init[]; /* table of init commands */ };
diff --git a/src/mainboard/google/kukui/panel_jacuzzi.c b/src/mainboard/google/kukui/panel_jacuzzi.c index d26e12c..0c49a24 100644 --- a/src/mainboard/google/kukui/panel_jacuzzi.c +++ b/src/mainboard/google/kukui/panel_jacuzzi.c @@ -46,6 +46,7 @@ static struct panel_description jacuzzi_panel = { .name = "eDP via PS8640", .power_on = dummy_power_on, + .orientation = LB_PANEL_ORIENTATION_NORMAL, .init = { {END_OF_TABLE, } }, };
diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c index 3e538c0..8c191ae 100644 --- a/src/mainboard/google/kukui/panel_krane.c +++ b/src/mainboard/google/kukui/panel_krane.c @@ -31,6 +31,7 @@ .x_mm = 135, .y_mm = 216, }, }, + .orientation = LB_PANEL_ORIENTATION_LEFT_UP, .init = { _INIT_DELAY_CMD(10), _INIT_DCS_CMD(0x11), @@ -57,6 +58,7 @@ .x_mm = 135, .y_mm = 216, }, }, + .orientation = LB_PANEL_ORIENTATION_LEFT_UP, .init = { _INIT_DELAY_CMD(24), _INIT_DCS_CMD(0xB0, 0x05), diff --git a/src/mainboard/google/kukui/panel_kukui.c b/src/mainboard/google/kukui/panel_kukui.c index f4b3e5b..5b0b810 100644 --- a/src/mainboard/google/kukui/panel_kukui.c +++ b/src/mainboard/google/kukui/panel_kukui.c @@ -53,6 +53,7 @@ .x_mm = 147, .y_mm = 196, }, }, + .orientation = LB_PANEL_ORIENTATION_NORMAL, .init = { _INIT_GENERIC_CMD(0xff, 0x00), /* LOCKCNT=0x1f4, MRX=0, POSTDIV=1 (/2} }, MULT=0x49
Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
Patch Set 1:
Depends on https://review.coreboot.org/c/coreboot/+/34732.
Arguably we can leave all the non-krane descriptions alone as NORMAL orientation is default/0.
Hello Julius Werner, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34733
to look at the new patch set (#2).
Change subject: mb/google/kukui: Setup display rotation ......................................................................
mb/google/kukui: Setup display rotation
Add orientation field to all kukui derivatives.
BUG=b:132049716 TEST=Boot krane, see that FW screen is orientation properly.
Change-Id: I1c56a069c008d760780bd185303d16cc8d960ca9 Signed-off-by: Nicolas Boichat drinkcat@chromium.org --- M 3rdparty/blobs M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel.h M src/mainboard/google/kukui/panel_jacuzzi.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 6 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34733/2
Hello Julius Werner, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34733
to look at the new patch set (#3).
Change subject: mb/google/kukui: Setup display rotation ......................................................................
mb/google/kukui: Setup display rotation
Add orientation field to all kukui derivatives.
BUG=b:132049716 TEST=Boot krane, see that FW screen is orientation properly.
Change-Id: I1c56a069c008d760780bd185303d16cc8d960ca9 Signed-off-by: Nicolas Boichat drinkcat@chromium.org --- M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel.h M src/mainboard/google/kukui/panel_jacuzzi.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c 5 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34733/3
Hello Julius Werner, Hung-Te Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34733
to look at the new patch set (#4).
Change subject: mb/google/kukui: Setup display rotation ......................................................................
mb/google/kukui: Setup display rotation
Add orientation field to all kukui derivatives.
BUG=b:132049716 TEST=Boot krane, see that FW screen is orientation properly.
Change-Id: I1c56a069c008d760780bd185303d16cc8d960ca9 Signed-off-by: Nicolas Boichat drinkcat@chromium.org --- M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/kukui/panel.h M src/mainboard/google/kukui/panel_kodama.c M src/mainboard/google/kukui/panel_krane.c M src/mainboard/google/kukui/panel_kukui.c M src/mainboard/google/kukui/panel_ps8640.c 6 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34733/4
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
Patch Set 4:
can be abandoned - this is now merged into parent CLs.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34733/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34733/4//COMMIT_MSG@7 PS4, Line 7: Setup Set up
Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34733/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34733/4//COMMIT_MSG@7 PS4, Line 7: Setup
Set up
I'll getit right next time ,-)
Nicolas Boichat has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34733 )
Change subject: mb/google/kukui: Setup display rotation ......................................................................
Abandoned
Squashed into previous CLs.
-
Hung-Te Lin (Code Review) -
Nicolas Boichat (Code Review)
-
Paul Menzel (Code Review)