Attention is currently required from: Ccong Chen, Hung-Te Lin, Jarried Lin, Yidi Lin.
Alicja Michalska has posted comments on this change by Ccong Chen. ( https://review.coreboot.org/c/coreboot/+/85599?usp=email )
Change subject: soc/meidatek/mt8196: Add SPM loader
......................................................................
Patch Set 8:
(2 comments)
File src/soc/mediatek/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/85599/comment/0e22cc76_520d3cff?usp... :
PS8, Line 122: version2
```suggestion
This option enables SPM Version 2. This version of the chip design
```
File src/soc/mediatek/mt8196/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/85599/comment/6df6eec8_17b9d14b?usp... :
PS8, Line 772: u32 isp_traw_pwr_con;
Any reason to remove those? Will this SoC not support MIPI cameras?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie09346f46cb734c74776b760485e7f35d4357e5e
Gerrit-Change-Number: 85599
Gerrit-PatchSet: 8
Gerrit-Owner: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-CC: Jarried Lin
jarried.lin@mediatek.com
Gerrit-CC: Wenzhen Yu
wenzhen.yu@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Ccong Chen
ot_ccong.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Thu, 19 Dec 2024 22:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No