Attention is currently required from: Jeff Daly, Mariusz Szafrański, Tim Wawrzynczak, Suresh Bellampalli, Paul Menzel, Vanessa Eusebio, Arthur Heymans.
Hello build bot (Jenkins), Jeff Daly, Subrata Banik, Mariusz Szafrański, Suresh Bellampalli, Paul Menzel, Tim Wawrzynczak, Vanessa Eusebio, Lean Sheng Tan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63788
to look at the new patch set (#5).
Change subject: cpu/intel/*: Set SMM SMRR code access check bit
......................................................................
cpu/intel/*: Set SMM SMRR code access check bit
This makes sure that only code in TSEG gets executed.
See section 34.17.1 "SMM Handler Code Access Control" in the 'Intel
64 and IA-32 Architectures Software Developer’s Manual'
Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7
Signed-off-by: Arthur Heymans arthur@aheymans.xyz
---
M src/cpu/intel/haswell/finalize.c
M src/include/cpu/intel/smm_reloc.h
M src/soc/intel/common/block/smm/smihandler.c
M src/soc/intel/denverton_ns/smihandler.c
4 files changed, 60 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/63788/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63788
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I254fb348483d2873917cf8c94c8b60e6f2d2c4e7
Gerrit-Change-Number: 63788
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: newpatchset