Attention is currently required from: Hung-Te Lin, Xi Chen, Rex-BC Chen, Yu-Ping Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59989 )
Change subject: soc/mediatek: add support for tracker version one
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59989/comment/2fc8e236_dbbd5dc9
PS1, Line 11:
Please mention the datasheet names, versions and sections.
File src/soc/mediatek/common/tracker.c:
https://review.coreboot.org/c/coreboot/+/59989/comment/92ed6a0e_2832cd47
PS1, Line 9: __weak void tracker_setup(void)
No weak function is needed, as it has to be implemented?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59989
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idb146974da118b1cf5a349370bf7b2fa13f1aba8
Gerrit-Change-Number: 59989
Gerrit-PatchSet: 1
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 11:41:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment