Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33736
Change subject: mainboard/facebook/fbg1701: Rename tc348860_table ......................................................................
mainboard/facebook/fbg1701: Rename tc348860_table
tc348860_table contains the eDP to MIPI Bridge controller type. b101uan08_table used the LCD Panel type. Use LCD Panel type for name of tables.
Remove the incomplete resolution comments and specify the resolution at the startof the table to 1200x1920.
BUG=N/A TEST=Config eDP and verify LCD panels are working on Facebook FBG-1701
Change-Id: Ic152ea1f95f155ab76638b57a259d37ce6f43037 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/ramstage.c 1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33736/1
diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index 3903a64..5c78bcc 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -28,8 +28,8 @@ u8 data[6]; } __packed;
-static const struct edp_data tc348860_table[] = { - /* set eDP bridge to eDP 1920 */ +static const struct edp_data b101uan01_table[] = { + /* set eDP bridge to 1200x1920 */ /* IO */ { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, /* Boot */ @@ -173,7 +173,7 @@ };
static const struct edp_data b101uan08_table[] = { - /* set eDP bridge to eDP 1920 */ + /* set eDP bridge to 1200x1920 */ /* IO Voltage Setting */ { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, /* Boot Settings */ @@ -333,7 +333,7 @@ CPLD_PCB_VERSION_BIT; printk(BIOS_DEBUG, "CPLD version: %x\n", cpld_version); if (cpld_version < 7) - edptable = tc348860_table; + edptable = b101uan01_table; else edptable = b101uan08_table;
@@ -341,7 +341,6 @@ outb(CPLD_CMD_RESET_DSI_BRIDGE_ACTIVE, CPLD_RESET_PORT); outb(CPLD_CMD_RESET_DSI_BRIDGE_INACTIVE, CPLD_RESET_PORT);
- /* set eDP bridge to eDP 1920 */ while (edptable->payload_length) { loops = 5; do { @@ -360,7 +359,6 @@
void mainboard_silicon_init_params(SILICON_INIT_UPD *params) { - /* Configure the eDP bridge to eDP 1920 */ mainboard_configure_edp_bridge();
if (CONFIG(FSP1_1_DISPLAY_LOGO)) {
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33736 )
Change subject: mainboard/facebook/fbg1701: Rename tc348860_table ......................................................................
Patch Set 1:
This patches contains update suggested in CB:33433
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33736 )
Change subject: mainboard/facebook/fbg1701: Rename tc348860_table ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG@11 PS1, Line 11: Use LCD Panel type for name of tables. Please put on the line above.
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG@14 PS1, Line 14: startof start of
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG@14 PS1, Line 14: 1200x1920 It’s horizontal, right?
Hello Felix Held, Angel Pons, build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33736
to look at the new patch set (#2).
Change subject: mainboard/facebook/fbg1701: Use LCD Panel type for name of tables ......................................................................
mainboard/facebook/fbg1701: Use LCD Panel type for name of tables
tc348860_table contains the eDP to MIPI Bridge controller type. b101uan08_table used the LCD Panel type. Use LCD Panel type for name of tables.
Remove the incomplete resolution comments and specify the resolution at the start of the table to 1200x1920.
BUG=N/A TEST=Config eDP and verify LCD panels are working on Facebook FBG-1701
Change-Id: Ic152ea1f95f155ab76638b57a259d37ce6f43037 Signed-off-by: Frans Hendriks fhendriks@eltan.com --- M src/mainboard/facebook/fbg1701/ramstage.c 1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/33736/2
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33736 )
Change subject: mainboard/facebook/fbg1701: Use LCD Panel type for name of tables ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG@11 PS1, Line 11: Use LCD Panel type for name of tables.
Please put on the line above.
Done
https://review.coreboot.org/#/c/33736/1//COMMIT_MSG@14 PS1, Line 14: startof
start of
Done
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33736 )
Change subject: mainboard/facebook/fbg1701: Use LCD Panel type for name of tables ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33736 )
Change subject: mainboard/facebook/fbg1701: Use LCD Panel type for name of tables ......................................................................
mainboard/facebook/fbg1701: Use LCD Panel type for name of tables
tc348860_table contains the eDP to MIPI Bridge controller type. b101uan08_table used the LCD Panel type. Use LCD Panel type for name of tables.
Remove the incomplete resolution comments and specify the resolution at the start of the table to 1200x1920.
BUG=N/A TEST=Config eDP and verify LCD panels are working on Facebook FBG-1701
Change-Id: Ic152ea1f95f155ab76638b57a259d37ce6f43037 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/33736 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/facebook/fbg1701/ramstage.c 1 file changed, 4 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/mainboard/facebook/fbg1701/ramstage.c b/src/mainboard/facebook/fbg1701/ramstage.c index 3903a64..5c78bcc 100644 --- a/src/mainboard/facebook/fbg1701/ramstage.c +++ b/src/mainboard/facebook/fbg1701/ramstage.c @@ -28,8 +28,8 @@ u8 data[6]; } __packed;
-static const struct edp_data tc348860_table[] = { - /* set eDP bridge to eDP 1920 */ +static const struct edp_data b101uan01_table[] = { + /* set eDP bridge to 1200x1920 */ /* IO */ { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, /* Boot */ @@ -173,7 +173,7 @@ };
static const struct edp_data b101uan08_table[] = { - /* set eDP bridge to eDP 1920 */ + /* set eDP bridge to 1200x1920 */ /* IO Voltage Setting */ { 6, 0x68, { 0x08, 0x00, 0x01, 0x00, 0x00, 0x00 } }, /* Boot Settings */ @@ -333,7 +333,7 @@ CPLD_PCB_VERSION_BIT; printk(BIOS_DEBUG, "CPLD version: %x\n", cpld_version); if (cpld_version < 7) - edptable = tc348860_table; + edptable = b101uan01_table; else edptable = b101uan08_table;
@@ -341,7 +341,6 @@ outb(CPLD_CMD_RESET_DSI_BRIDGE_ACTIVE, CPLD_RESET_PORT); outb(CPLD_CMD_RESET_DSI_BRIDGE_INACTIVE, CPLD_RESET_PORT);
- /* set eDP bridge to eDP 1920 */ while (edptable->payload_length) { loops = 5; do { @@ -360,7 +359,6 @@
void mainboard_silicon_init_params(SILICON_INIT_UPD *params) { - /* Configure the eDP bridge to eDP 1920 */ mainboard_configure_edp_bridge();
if (CONFIG(FSP1_1_DISPLAY_LOGO)) {
-
Felix Held (Code Review) -
Frans Hendriks (Code Review)
-
Kyösti Mälkki (Code Review)
-
Paul Menzel (Code Review)