Attention is currently required from: Jason Nien, Martin Roth.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72455 )
Change subject: mb/google/skyrim: Add EC_HOST_EVENT_PANIC to SCI mask ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72455/comment/46b75463_1c34d17b PS1, Line 10: If system safe mode is also enabled : on the EC, the kernel will have a short period to extract and save info : about the EC panic.
Thanks for the detailed explanations. […]
EC does a system reset which will toggle EC_SYS_RST_L, which toggles SYS_RESET_L on the AP. So AP state will be cleared.
https://review.coreboot.org/c/coreboot/+/72455/comment/d96dbe30_c7759446 PS1, Line 16: TEST=Observe kernel ec panic handler run when ec panics
LGTM
No surprises when testing each scenario: 1. System reboots. No sign in kernel or AP logs that the SCI was received before rebooting. 2. Safe mode starts, no new logs in kernel, handler does not run, EC reboots. 3. System reboots. No sign in kernel or AP logs that the SCI was received before rebooting. 4. Safe mode starts, kernel handler runs and flushes log. /var/log/cros_ec.previous contains EC log. /var/log/messages shows 'CrOS EC Panic Reported. Shutdown is imminent!'
-
Rob Barnes (Code Review)