Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74344 )
Change subject: soc/amd/common: Identify FSP HOB type GUIDs
......................................................................
Patch Set 1:
(2 comments)
File src/soc/amd/common/fsp/hob_display.c:
PS1:
i personally would prefer to use the coreboot type guid_t and the macro GUID_INIT instead of the EFI […]
The reason I chose this representation is because it allows us to more easily search for the guids in the AGESA FSP source.
If the coreboot GUID_INIT function used a uint64_t for the last segment instead of 8 uint8_t values, I'd support it. That would match the standard GUID representation instead of doing our own thing.
https://review.coreboot.org/c/coreboot/+/74344/comment/1868dff9_0afa36bf
PS1, Line 5: #include <lib.h>
i don't see what this is needed for. you'll need to include types. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74344
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e0b4c3e3c7b6271ac64f9296c8a3f46d28e244d
Gerrit-Change-Number: 74344
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 24 Apr 2023 21:28:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment