Attention is currently required from: Raul Rangel, Martin Roth, Angel Pons.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49833 )
Change subject: bayhub bh720: Factor out common HS200 init code
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/generic/bayhub/bh720.c:
https://review.coreboot.org/c/coreboot/+/49833/comment/a06f250d_ff0f6be4
PS1, Line 89: bh720_program_hs200_mode(dev);
I decided to keep this as a separate function for clarity, especially if one wants to extend it late […]
yes, take 0x2510 as parameter like you did for VIH. This should be fine for any clocks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49833
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82635a289e3c05119eab4ee1f7a6bf3a8a1725c1
Gerrit-Change-Number: 49833
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 15:46:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment