Change in coreboot[4.11_branch]: sec/intel/txt/Kconfig: Remove the menu for including ACMs
Hello Arthur Heymans,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45003
to review the following change.
Change subject: sec/intel/txt/Kconfig: Remove the menu for including ACMs ......................................................................
sec/intel/txt/Kconfig: Remove the menu for including ACMs
This is consistent with how other binaries (e.g. FSP) are added via Kconfig. This also makes it more visible that things need to be configured.
Change-Id: I399de6270cc4c0ab3b8c8a9543aec0d68d3cfc03 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/security/intel/txt/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/45003/1
diff --git a/src/security/intel/txt/Kconfig b/src/security/intel/txt/Kconfig index d828a9d..049705f 100644 --- a/src/security/intel/txt/Kconfig +++ b/src/security/intel/txt/Kconfig @@ -26,8 +26,6 @@
if INTEL_TXT
-menu "Intel" - config INTEL_TXT_BIOSACM_FILE string "BIOS ACM file" default "3rdparty/blobs/soc/intel/fsp_broadwell_de/biosacm.bin" if SOC_INTEL_FSP_BROADWELL_DE @@ -71,6 +69,4 @@ string default "txt_sinit_acm.bin"
-endmenu # Intel - endif
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45003 )
Change subject: sec/intel/txt/Kconfig: Remove the menu for including ACMs ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45003 )
Change subject: sec/intel/txt/Kconfig: Remove the menu for including ACMs ......................................................................
sec/intel/txt/Kconfig: Remove the menu for including ACMs
This is consistent with how other binaries (e.g. FSP) are added via Kconfig. This also makes it more visible that things need to be configured.
Change-Id: I399de6270cc4c0ab3b8c8a9543aec0d68d3cfc03 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/45003 Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/intel/txt/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/security/intel/txt/Kconfig b/src/security/intel/txt/Kconfig index d828a9d..049705f 100644 --- a/src/security/intel/txt/Kconfig +++ b/src/security/intel/txt/Kconfig @@ -26,8 +26,6 @@
if INTEL_TXT
-menu "Intel" - config INTEL_TXT_BIOSACM_FILE string "BIOS ACM file" default "3rdparty/blobs/soc/intel/fsp_broadwell_de/biosacm.bin" if SOC_INTEL_FSP_BROADWELL_DE @@ -71,6 +69,4 @@ string default "txt_sinit_acm.bin"
-endmenu # Intel - endif
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)