Change in coreboot[master]: sb/intel/i82801dx: Drop unused parameter

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34819 )

Change subject: sb/intel/i82801dx: Drop unused parameter
......................................................................

sb/intel/i82801dx: Drop unused parameter

Change-Id: I4aaa67ba3de82b07e0e278be39a93a482bbf09c4
Signed-off-by: Kyösti Mälkki 
---
M src/southbridge/intel/i82801dx/smihandler.c
1 file changed, 13 insertions(+), 14 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/34819/1

diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 18dc4d8..944adc3 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -268,7 +268,7 @@
 }

-static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_sleep(void)
 {
    u8 reg8;
    u32 reg32;
@@ -341,7 +341,7 @@
    }
 }

-static void southbridge_smi_apmc(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_apmc(void)
 {
    u32 pmctrl;
    u8 reg8;
@@ -403,7 +403,7 @@
    }
 }

-static void southbridge_smi_pm1(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_pm1(void)
 {
    u16 pm1_sts;

@@ -421,7 +421,7 @@
    }
 }

-static void southbridge_smi_gpe0(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_gpe0(void)
 {
    u32 gpe0_sts;

@@ -429,7 +429,7 @@
    dump_gpe0_status(gpe0_sts);
 }

-static void southbridge_smi_gpi(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_gpi(void)
 {
    u16 reg16;
    reg16 = inw(pmbase + ALT_GP_SMI_STS);
@@ -443,7 +443,7 @@
    	printk(BIOS_DEBUG, "GPI (mask %04x)\n",reg16);
 }

-static void southbridge_smi_mc(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_mc(void)
 {
    u32 reg32;

@@ -458,7 +458,7 @@

-static void southbridge_smi_tco(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_tco(void)
 {
    u32 tco_sts;

@@ -495,7 +495,7 @@
    }
 }

-static void southbridge_smi_periodic(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_periodic(void)
 {
    u32 reg32;

@@ -508,7 +508,7 @@
    printk(BIOS_DEBUG, "Periodic SMI.\n");
 }

-static void southbridge_smi_monitor(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_monitor(void)
 {
 #define IOTRAP(x) (trap_sts & (1 << x))
 #if 0
@@ -564,8 +564,7 @@
 #undef IOTRAP
 }

-typedef void (*smi_handler_t)(unsigned int node,
-		smm_state_save_area_t *state_save);
+typedef void (*smi_handler_t)(void);

smi_handler_t southbridge_smi[32] = {
    NULL,			  //  [0] reserved
@@ -627,9 +626,9 @@
    /* Call SMI sub handler for each of the status bits */
    for (i = 0; i < 31; i++) {
    	if (smi_sts & (1 << i)) {
-			if (southbridge_smi[i])
-				southbridge_smi[i](node, state_save);
-			else {
+			if (southbridge_smi[i]) {
+				southbridge_smi[i]();
+			} else {
    			printk(BIOS_DEBUG, "SMI_STS[%d] occurred, but no "
    					"handler available.\n", i);
    			dump = 1;

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34819 )

Change subject: sb/intel/i82801dx: Drop unused parameter
......................................................................

Patch Set 2: Code-Review+2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34819 )

Change subject: sb/intel/i82801dx: Drop unused parameter
......................................................................

Patch Set 2: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34819 )

Change subject: sb/intel/i82801dx: Drop unused parameter
......................................................................

Patch Set 2: Code-Review+2

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34819 )

Change subject: sb/intel/i82801dx: Drop unused parameter
......................................................................

sb/intel/i82801dx: Drop unused parameter

Change-Id: I4aaa67ba3de82b07e0e278be39a93a482bbf09c4
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34819
Reviewed-by: Arthur Heymans 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
Tested-by: build bot (Jenkins) 
---
M src/southbridge/intel/i82801dx/smihandler.c
1 file changed, 13 insertions(+), 14 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/intel/i82801dx/smihandler.c b/src/southbridge/intel/i82801dx/smihandler.c
index 18dc4d8..944adc3 100644
--- a/src/southbridge/intel/i82801dx/smihandler.c
+++ b/src/southbridge/intel/i82801dx/smihandler.c
@@ -268,7 +268,7 @@
 }

-static void southbridge_smi_sleep(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_sleep(void)
 {
    u8 reg8;
    u32 reg32;
@@ -341,7 +341,7 @@
    }
 }

-static void southbridge_smi_apmc(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_apmc(void)
 {
    u32 pmctrl;
    u8 reg8;
@@ -403,7 +403,7 @@
    }
 }

-static void southbridge_smi_pm1(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_pm1(void)
 {
    u16 pm1_sts;

@@ -421,7 +421,7 @@
    }
 }

-static void southbridge_smi_gpe0(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_gpe0(void)
 {
    u32 gpe0_sts;

@@ -429,7 +429,7 @@
    dump_gpe0_status(gpe0_sts);
 }

-static void southbridge_smi_gpi(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_gpi(void)
 {
    u16 reg16;
    reg16 = inw(pmbase + ALT_GP_SMI_STS);
@@ -443,7 +443,7 @@
    	printk(BIOS_DEBUG, "GPI (mask %04x)\n",reg16);
 }

-static void southbridge_smi_mc(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_mc(void)
 {
    u32 reg32;

@@ -458,7 +458,7 @@

-static void southbridge_smi_tco(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_tco(void)
 {
    u32 tco_sts;

@@ -495,7 +495,7 @@
    }
 }

-static void southbridge_smi_periodic(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_periodic(void)
 {
    u32 reg32;

@@ -508,7 +508,7 @@
    printk(BIOS_DEBUG, "Periodic SMI.\n");
 }

-static void southbridge_smi_monitor(unsigned int node, smm_state_save_area_t *state_save)
+static void southbridge_smi_monitor(void)
 {
 #define IOTRAP(x) (trap_sts & (1 << x))
 #if 0
@@ -564,8 +564,7 @@
 #undef IOTRAP
 }

-typedef void (*smi_handler_t)(unsigned int node,
-		smm_state_save_area_t *state_save);
+typedef void (*smi_handler_t)(void);

smi_handler_t southbridge_smi[32] = {
    NULL,			  //  [0] reserved
@@ -627,9 +626,9 @@
    /* Call SMI sub handler for each of the status bits */
    for (i = 0; i < 31; i++) {
    	if (smi_sts & (1 << i)) {
-			if (southbridge_smi[i])
-				southbridge_smi[i](node, state_save);
-			else {
+			if (southbridge_smi[i]) {
+				southbridge_smi[i]();
+			} else {
    			printk(BIOS_DEBUG, "SMI_STS[%d] occurred, but no "
    					"handler available.\n", i);
    			dump = 1;