Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang, Selma Bensaid, Sridhar Siricilla, Bernardo Perez Priego. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58101 )
Change subject: lib/spd_bin: Fix for LDDR5 ......................................................................
Patch Set 5:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58101/comment/aea03dc7_341ee60a PS5, Line 9: Added LDDR5 for the param : Fixed SPD name for LDDR5 Please format it as a list, and use imperative mood (Add, Fix).
https://review.coreboot.org/c/coreboot/+/58101/comment/798decd5_2c0f5435 PS5, Line 11: with this change, we won't get this warning message: Please add a blank line above, and maybe just write:
This addresses the warning below:
https://review.coreboot.org/c/coreboot/+/58101/comment/fc2f20f9_a568f42f PS5, Line 11: with With
File src/lib/spd_bin.c:
https://review.coreboot.org/c/coreboot/+/58101/comment/9e6eeea8_6a770cfe PS5, Line 27: use_ddr4_params This name should be updated, if DDR5 is also handled.
https://review.coreboot.org/c/coreboot/+/58101/comment/10dc8e53_39b01162 PS5, Line 37: case SPD_DRAM_LPDDR5: Please order it one line below.
https://review.coreboot.org/c/coreboot/+/58101/comment/92db4420_83638dac PS5, Line 169: case SPD_DRAM_LPDDR5: Please order it below.
-
Paul Menzel (Code Review)