Attention is currently required from: Tarun Tuli, Subrata Banik, Angel Pons, Lean Sheng Tan, Werner Zeh.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71574 )
Change subject: security/intel/txt: Helper function to disable TXT
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1:
Looks good. What do you think of my suggestion for a different function name? I don't feel strongly about it. I just reviewed the follow-up first and got confused, hence the suggestion.
File src/security/intel/txt/txtlib.c:
https://review.coreboot.org/c/coreboot/+/71574/comment/d1b191b5_07c0cf3e
PS1, Line 57: /* Don't disable if INTEL_TXT config is selected */
: if (CONFIG(INTEL_TXT))
: return;
Having a disable function which does not disable anything depending on a Kconfig value, is a bit confusing? Would it make sense to call it something like 'early_intel_txt_setup' ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71574
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27f613428e82a1dd924172eab853d2ce9c32b473
Gerrit-Change-Number: 71574
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Fri, 06 Jan 2023 08:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment