Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36211 )
Change subject: cpu/intel/car: Add EC software sync to Intel romstage ......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Romstage starts here for all Intel platforms. I don't think it makes sense to put platforms specific things here.
https://review.coreboot.org/c/coreboot/+/36211/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36211/1//COMMIT_MSG@9 PS1, Line 9: Perform EC software sync in romstage, before memory training is started. Explain why.
https://review.coreboot.org/c/coreboot/+/36211/1/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/36211/1/src/cpu/intel/car/romstage.... PS1, Line 42: if Don't use preprocessor.
https://review.coreboot.org/c/coreboot/+/36211/1/src/cpu/intel/car/romstage.... PS1, Line 62: "Failed to sync EC!\n"); On platforms without C_ENVIRONMENT_BOOTBLOCK console is not initialized here.
-
Arthur Heymans (Code Review)