[M] Change in coreboot[main]: mb/google/fatcat: Add Panther Lake SOC support - coreboot-gerrit

18 Sep 2024


      Attention is currently required from: Ashish Kumar Mishra, Cliff Huang, Felix Held, Jérémy Compostella, Paul Menzel, Pranava Y N, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support
......................................................................
Patch Set 180:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/83419/comment/bfcb2750_0255377b?usp... :
PS180, Line 49: CROS_GPIO_DEVICE0_NAME
...
why `DEVICE0` ?
move to GPIO CL
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/83419?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5e
Gerrit-Change-Number: 83419
Gerrit-PatchSet: 180
Gerrit-Owner: Saurabh Mishra mishra.saurabh@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anil Kumar K anil.kumar.k@intel.com
Gerrit-CC: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik bora.guvendik@intel.com
Gerrit-CC: Cliff Huang cliff.huang@intel.com
Gerrit-CC: Hannah Williams hannah.williams@intel.com
Gerrit-CC: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-CC: Sanju Jose Thottan sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja vikrant.l.jadeja@intel.com
Gerrit-CC: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra ashish.k.mishra@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Pranava Y N pranavayn@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 18 Sep 2024 02:44:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com