Attention is currently required from: Felix Singer, Paul Menzel, Michał Kopeć, Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )
Change subject: mainboard/msi/ms7d25: Add support for DDR5 variant ......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68448/comment/3f12186b_9ed01ad3 PS3, Line 12: TEST=Boot MSI PRO Z690-A board successfully to Ubuntu 22.04.
It’d be great if you added, what DIMMs you tested with.
Done
File src/mainboard/msi/ms7d25/Kconfig:
https://review.coreboot.org/c/coreboot/+/68448/comment/8509926b_4cb22510 PS3, Line 4: config BOARD_MSI_Z690_A_PRO_WIFI
If this is the DDR5 variant, why not append `_DDR5`?
It is just Kconfig name and does not really matter. I can add it if you say so, but I wanted to match the board's name displayed in SMBIOS
File src/mainboard/msi/ms7d25/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/68448/comment/b33e7dd3_273e0d5e PS3, Line 2: bool "PRO Z690-A (WIFI) DDR4"
… or mention it in the commit message.
WIFI is optional here thus the parentheses. It does not change the port in any way except the SMBIOS string.
-
Michał Żygowski (Code Review)