Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73087 )
Change subject: mb/intel/dq67sw: Add LGA1155 microATX mainboard
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Thank you for your reply.
- I think the correct way would be to add this to the Kconfig in a new patch?
Yes, I think that is the way to go.
Regarding 1., it looks like a bug in `cbfstool`. An issue should probably created to track it.
Regarding 3., hopefully somebody can shed some light on it. Gerrit comments are probably not the right forum for such discussions. If nobody responds, this issue should be brought up on the mailing list.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc703f2d0ad45495e71d3f7799347430f5196791
Gerrit-Change-Number: 73087
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Büchler
michael.buechler@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 11 Apr 2023 21:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment