build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30021 )
Change subject: mainboard/lenovo/t430s: Add ThinkPad T431s as a variant ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t430s/hda_verb.c:
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 92: combo Jack code indent should use tabs where possible
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 93: Master Port - Port B used for Jack Presence Detect code indent should use tabs where possible
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 94: Enable Combo Jack Detection */ code indent should use tabs where possible
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 124: 0x02177a00, /* Digital PCBEEP Gain: 0h=-9db, 1h=-6db ... 4h=+3db, 5h=+6db */ line over 80 characters
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... File src/mainboard/lenovo/t430s/variants/t430s/romstage.c:
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 57: void mainboard_get_spd(spd_raw_data *spd, bool id_only) { open brace '{' following function definitions go on the next line
https://review.coreboot.org/#/c/30021/7/src/mainboard/lenovo/t430s/variants/... PS7, Line 62: void mainboard_early_init(int s3resume) { open brace '{' following function definitions go on the next line
-
build bot (Jenkins) (Code Review)