Attention is currently required from: Bao Zheng, Jason Nien, Zheng Bao.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68884 )
Change subject: stoneyridge: Set the SPI read speed as 66MHz
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68884/comment/c284323e_e6b20811
PS1, Line 7: stoneyridge: Set the SPI
Isn't this changing the read MODE, not the speed?
I think we still want to use dual SPI, not single SPI.
I'm not convinced that this is right.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia6083cfa515abeb2e981ff0ef825970c9311466b
Gerrit-Change-Number: 68884
Gerrit-PatchSet: 1
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Sun, 30 Oct 2022 17:05:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment