Attention is currently required from: Jon Murphy, Martin Roth.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Sorry, I meant querying what the device is over i2c.
we'd probably want that as an optional 2nd step beyond just presence detection, but IMO this is exactly the problem SSFC exists to solve, so I'm not sure why it wasn't used here from the start
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83606?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Gerrit-Change-Number: 83606
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jon Murphy
jpmurphy@google.com
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Jul 2024 21:13:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com