Attention is currently required from: Raul Rangel, Jon Murphy, Mark Hasemeyer.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74110 )
Change subject: mb/google/myst: Add eSPI configuration
......................................................................
Patch Set 30:
(1 comment)
File src/mainboard/google/myst/bootblock.c:
https://review.coreboot.org/c/coreboot/+/74110/comment/a73bbc63_0dcf9f11
PS30, Line 14: }
looking at the espi_gpio_table, you're using spi1 for espi, so you're missing the espi_switch_to_spi1_pads call at the end of this function. see skyrim's mb_set_up_early_espi implementation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74110
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b40adec78d4e0b596596fa6e2951c79bd3bd8c7
Gerrit-Change-Number: 74110
Gerrit-PatchSet: 30
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 13:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment