Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Angel Pons, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62838 )
Change subject: soc/intel/common/block/cpu: Enable ROM caching in ramstage
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62838/comment/7172e466_aa7d1ad3
PS1, Line 9: This patch ensures to have `BIOS region` and `extended BIOS` region is
: cached if the boot device is memory mapped
Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/62838/comment/c7a6f335_c4ac9e51
PS1, Line 9: This patch ensures to have `BIOS region` and `extended BIOS` region is
: cached if the boot device is memory mapped, which is mostly the case
: with Intel SoC platform.
Why should this be done? Lower boot time?
Ack
https://review.coreboot.org/c/coreboot/+/62838/comment/2a16ec4a_982a2753
PS1, Line 12:
Tested on what device?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62838
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I02b80eefbb3b19331698a205251a0c4d17be534c
Gerrit-Change-Number: 62838
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subi.banik@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 15:26:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment