Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36190 )
Change subject: mb/google/octopus: Override VBT selection for Blooglet ......................................................................
mb/google/octopus: Override VBT selection for Blooglet
Share the same vbt_blooguard.bin to disalbe DRRS support.
BUG=b:143045247 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage check i915_drrs_status shows DRRS supported NO when SKU ID is blooglet.
Change-Id: Ia180f265080f801a09f10ce8a8b520c47f218775 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com --- M src/mainboard/google/octopus/variants/bloog/variant.c 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/36190/1
diff --git a/src/mainboard/google/octopus/variants/bloog/variant.c b/src/mainboard/google/octopus/variants/bloog/variant.c index 4bbaa8e..18f44b9 100644 --- a/src/mainboard/google/octopus/variants/bloog/variant.c +++ b/src/mainboard/google/octopus/variants/bloog/variant.c @@ -30,6 +30,10 @@ SKU_50_BLOOGUARD = 50, /* kb blit, USI Stylus */ SKU_51_BLOOGUARD = 51, /* no kb blit, no USI Stylus */ SKU_52_BLOOGUARD = 52, /* no kb blit, USI Stylus */ + SKU_65_BLOOGLET = 65, /* TS, kb blit */ + SKU_66_BLOOGLET = 66, /* TS, no kb blit */ + SKU_67_BLOOGLET = 67, /* non-TS, kb blit */ + SKU_68_BLOOGLET = 68, /* non-TS, no kb blit */ };
const char *get_wifi_sar_cbfs_filename(void) @@ -59,7 +63,9 @@ sku_id = get_board_sku();
if (sku_id == SKU_49_BLOOGUARD || sku_id == SKU_50_BLOOGUARD || - sku_id == SKU_51_BLOOGUARD || sku_id == SKU_52_BLOOGUARD) + sku_id == SKU_51_BLOOGUARD || sku_id == SKU_52_BLOOGUARD || + sku_id == SKU_65_BLOOGLET || sku_id == SKU_66_BLOOGLET || + sku_id == SKU_67_BLOOGLET || sku_id == SKU_68_BLOOGLET) return "vbt_blooguard.bin";
return "vbt.bin";
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36190 )
Change subject: mb/google/octopus: Override VBT selection for Blooglet ......................................................................
Patch Set 1: Code-Review+2
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36190 )
Change subject: mb/google/octopus: Override VBT selection for Blooglet ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36190 )
Change subject: mb/google/octopus: Override VBT selection for Blooglet ......................................................................
mb/google/octopus: Override VBT selection for Blooglet
Share the same vbt_blooguard.bin to disalbe DRRS support.
BUG=b:143045247 BRANCH=octopus TEST=emerge-octopus coreboot chromeos-bootimage check i915_drrs_status shows DRRS supported NO when SKU ID is blooglet.
Change-Id: Ia180f265080f801a09f10ce8a8b520c47f218775 Signed-off-by: Tony Huang tony-huang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36190 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/octopus/variants/bloog/variant.c 1 file changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/octopus/variants/bloog/variant.c b/src/mainboard/google/octopus/variants/bloog/variant.c index 4bbaa8e..18f44b9 100644 --- a/src/mainboard/google/octopus/variants/bloog/variant.c +++ b/src/mainboard/google/octopus/variants/bloog/variant.c @@ -30,6 +30,10 @@ SKU_50_BLOOGUARD = 50, /* kb blit, USI Stylus */ SKU_51_BLOOGUARD = 51, /* no kb blit, no USI Stylus */ SKU_52_BLOOGUARD = 52, /* no kb blit, USI Stylus */ + SKU_65_BLOOGLET = 65, /* TS, kb blit */ + SKU_66_BLOOGLET = 66, /* TS, no kb blit */ + SKU_67_BLOOGLET = 67, /* non-TS, kb blit */ + SKU_68_BLOOGLET = 68, /* non-TS, no kb blit */ };
const char *get_wifi_sar_cbfs_filename(void) @@ -59,7 +63,9 @@ sku_id = get_board_sku();
if (sku_id == SKU_49_BLOOGUARD || sku_id == SKU_50_BLOOGUARD || - sku_id == SKU_51_BLOOGUARD || sku_id == SKU_52_BLOOGUARD) + sku_id == SKU_51_BLOOGUARD || sku_id == SKU_52_BLOOGUARD || + sku_id == SKU_65_BLOOGLET || sku_id == SKU_66_BLOOGLET || + sku_id == SKU_67_BLOOGLET || sku_id == SKU_68_BLOOGLET) return "vbt_blooguard.bin";
return "vbt.bin";
-
Justin TerAvest (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)
-
Tony Huang (Code Review)