Attention is currently required from: Andrey Petrov, Arthur Heymans, Frans Hendriks, Paul Menzel, Yu-Ping Wu.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63419?usp=email )
Change subject: Don't build a separate romstage by default on most x86 targets
......................................................................
Patch Set 55:
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/63419/comment/29184071_b9614350 :
PS55, Line 248: default y
Could you separate the patch that removes the default here? Then I can redefine that value inside an SOC Kconfig without waiting until the discussion for this patch is over.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63419?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c53b6fa7a3e66415c5b1c539918a6c1cd8defa1
Gerrit-Change-Number: 63419
Gerrit-PatchSet: 55
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Erik van den Bogaert
ebogaert@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Sun, 18 Feb 2024 12:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment