[M] Change in coreboot[main]: mb/google/rauru: Add 2nd source tas2563 amps to support beep

[Darren Ye (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Darren Ye has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85360?usp=email )

Change subject: mb/google/rauru: Add 2nd source tas2563 amps to support beep
......................................................................

Patch Set 3:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85360/comment/e10b65f0_cf8eec4b?usp... :
PS1, Line 10:
> Please mention the audio amps in the commit message.

Done

https://review.coreboot.org/c/coreboot/+/85360/comment/1fc79371_b60742fb?usp... :
PS1, Line 11: TEST=build pass and driver init ok
> Please paste the new log messages.

Done

File src/mainboard/google/rauru/chromeos.c:

https://review.coreboot.org/c/coreboot/+/85360/comment/cbae218e_8fbf8834?usp... :
PS1, Line 47: set gpios for NAU8318 amps\n");
            : 	} else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
            : 		struct lb_gpio smartamp_gpios[] = {
            : 			{GPIO_EN_SPKR.id, ACTIVE_LOW, -1, "speaker reset"},
            : 		};
            : 		lb_add_gpios(gpios, smartamp_gpios, ARRAY_SIZE(smartamp_gpios));
            : 		printk(BIOS_INFO, "set gpios for TAS2563 amps\n");
            : 	} else {
            : 		lb_add_gpios(gpios, nau8318_gpios, ARRAY_SIZE(nau8318_gpios));
            : 		printk(BIOS_INFO, "set gpios for default amps NAU8318
> as these are info level messages, I’d use the official spelling. For examples: […]

Done

https://review.coreboot.org/c/coreboot/+/85360/comment/621d543d_4f1c73de?usp... :
PS1, Line 40: 	struct lb_gpio nau8318_gpios[] = {
            : 		{GPIO_EN_SPKR.id, ACTIVE_HIGH, -1, "speaker enable"},
            : 		{GPIO_BEEP_ON_OD.id, ACTIVE_HIGH, -1, "beep enable"},
            : 	};
            : 
            : 	if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) {
            : 		lb_add_gpios(gpios, nau8318_gpios, ARRAY_SIZE(nau8318_gpios));
            : 		printk(BIOS_INFO, "set gpios for NAU8318 amps\n");
            : 	} else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
            : 		struct lb_gpio smartamp_gpios[] = {
            : 			{GPIO_EN_SPKR.id, ACTIVE_LOW, -1, "speaker reset"},
            : 		};
            : 		lb_add_gpios(gpios, smartamp_gpios, ARRAY_SIZE(smartamp_gpios));
            : 		printk(BIOS_INFO, "set gpios for TAS2563 amps\n");
            : 	} else {
            : 		lb_add_gpios(gpios, nau8318_gpios, ARRAY_SIZE(nau8318_gpios));
            : 		printk(BIOS_INFO, "set gpios for default amps NAU8318\n");
            : 	}
>

Done

File src/mainboard/google/rauru/mainboard.c:

https://review.coreboot.org/c/coreboot/+/85360/comment/df7d37ef_18bb4c05?usp... :
PS1, Line 20: 	printk(BIOS_INFO, "%s\n", __func__);
> remove

Done

https://review.coreboot.org/c/coreboot/+/85360/comment/f98c7e0b_76f70b06?usp... :
PS1, Line 20: 	printk(BIOS_INFO, "%s\n", __func__);
> This looks like a debug message?

Done

https://review.coreboot.org/c/coreboot/+/85360/comment/f71aa505_9208699e?usp... :
PS1, Line 33: printk(BIOS_INFO, "Audio configure.\n");
            : 
            : 	if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) {
            : 		printk(BIOS_INFO, "Audio configure NAU8318\n");
            : 	} else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
            : 		mtk_i2c_bus_init(I2C3, I2C_SPEED_FAST);
            : 		configure_i2s();
            : 		printk(BIOS_INFO, "Audio configure TAS2563\n");
            : 	} else {
            : 		printk(BIOS_INFO, "Audio configure default amps NAU8318\n");
> Please optimize the log messages?

Done

https://review.coreboot.org/c/coreboot/+/85360/comment/879fe765_6f3d6796?usp... :
PS1, Line 35: if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_NAU8318))) {
            : 		printk(BIOS_INFO, "Audio configure NAU8318\n");
            : 	} else if (fw_config_probe(FW_CONFIG(AUDIO_AMP, AMP_TAS2563))) {
            : 		mtk_i2c_bus_init(I2C3, I2C_SPEED_FAST);
            : 		configure_i2s();
            : 		printk(BIOS_INFO, "Audio configure TAS2563\n");
            : 	} else {
            : 		printk(BIOS_INFO, "Audio configure default amps NAU8318\n");
            : 	}
> We don't need to leave the log message everywhere. […]

Done