Attention is currently required from: Maximilian Brune, Andrey Petrov.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68592 )
Change subject: drivers/intel/fsp2_0/memory_init.c: clean code
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68592/comment/ccd64bee_605343d1
PS3, Line 9: No need to call a function that just instantly returns. It greatly enhances readability to just check before calling a funtion and it also removes an extra argument.
Please wrap at 72 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68592
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d57c45ede520160ef615725c023b7e92289a995
Gerrit-Change-Number: 68592
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Sat, 05 Nov 2022 16:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment