Attention is currently required from: Raul Rangel, Philipp Hug, Arthur Heymans, ron minnich.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60253 )
Change subject: [RFC] smp/spinlock: Use compiler builtins
......................................................................
Patch Set 6:
(2 comments)
File src/include/smp/spinlock.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143444):
https://review.coreboot.org/c/coreboot/+/60253/comment/e85e214f_df2b96d5
PS6, Line 11: #define DECLARE_SPIN_LOCK(x) static struct spinlock x;
macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143444):
https://review.coreboot.org/c/coreboot/+/60253/comment/aef352a1_de22d522
PS6, Line 27: while (!spinlock_try_lock(lock)) {
braces {} are not necessary for single statement blocks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60253
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6694784aa0810cd877886ef95434f62e3aefce6c
Gerrit-Change-Number: 60253
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 05:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment