Change in ...coreboot[master]: Revert "Documentation: Our coding style now allows 80 + 2*8 columns i...
Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31915
Change subject: Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line" ......................................................................
Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line"
This reverts commit b3a8cc54dbaf833c590a56f912209a5632b71f49.
This change was submitted under the incorrect assumption that there was agreement on a coding style change. There wasn't, so while the issue is under discussion we should revert to the previous status quo.
Change-Id: I37a5585764346af11a98bdf58c810dd3cf5bfe40 --- M Documentation/coding_style.md 1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31915/1
diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index e034193..048b8e6 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -30,11 +30,6 @@ more than 3 levels of indentation, you're screwed anyway, and should fix your program.
-Since most code in a file is indented at least 1 level, we account for -2 levels in addition to the 80 characters on the terminal under the -assumption that editors can scroll to the right, making an 80 characters -screen visible with little loss on the left end. - In short, 8-char indents make things easier to read, and have the added benefit of warning you when you're nesting your functions too deep. Heed that warning. @@ -85,11 +80,11 @@ Coding style is all about readability and maintainability using commonly available tools.
-The limit on the length of lines is 96 columns (80 columns + 2 tab levels) -and this is a strongly preferred limit. +The limit on the length of lines is 80 columns and this is a strongly +preferred limit.
-Statements longer than 96 columns will be broken into sensible chunks, -unless exceeding 96 columns significantly increases readability and does +Statements longer than 80 columns will be broken into sensible chunks, +unless exceeding 80 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31915
to look at the new patch set (#2).
Change subject: Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line" ......................................................................
Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line"
This reverts commit b3a8cc54dbaf833c590a56f912209a5632b71f49.
This change was submitted under the incorrect assumption that there was agreement on a coding style change. There wasn't, so while the issue is under discussion we should revert to the previous status quo.
Change-Id: I37a5585764346af11a98bdf58c810dd3cf5bfe40 Signed-off-by: Julius Werner jwerner@chromium.org --- M Documentation/coding_style.md 1 file changed, 4 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31915/2
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31915 )
Change subject: Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line" ......................................................................
Patch Set 2: Code-Review+2
Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31915 )
Change subject: Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line" ......................................................................
Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line"
This reverts commit b3a8cc54dbaf833c590a56f912209a5632b71f49.
This change was submitted under the incorrect assumption that there was agreement on a coding style change. There wasn't, so while the issue is under discussion we should revert to the previous status quo.
Change-Id: I37a5585764346af11a98bdf58c810dd3cf5bfe40 Signed-off-by: Julius Werner jwerner@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/31915 Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Documentation/coding_style.md 1 file changed, 4 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved
diff --git a/Documentation/coding_style.md b/Documentation/coding_style.md index e034193..048b8e6 100644 --- a/Documentation/coding_style.md +++ b/Documentation/coding_style.md @@ -30,11 +30,6 @@ more than 3 levels of indentation, you're screwed anyway, and should fix your program.
-Since most code in a file is indented at least 1 level, we account for -2 levels in addition to the 80 characters on the terminal under the -assumption that editors can scroll to the right, making an 80 characters -screen visible with little loss on the left end. - In short, 8-char indents make things easier to read, and have the added benefit of warning you when you're nesting your functions too deep. Heed that warning. @@ -85,11 +80,11 @@ Coding style is all about readability and maintainability using commonly available tools.
-The limit on the length of lines is 96 columns (80 columns + 2 tab levels) -and this is a strongly preferred limit. +The limit on the length of lines is 80 columns and this is a strongly +preferred limit.
-Statements longer than 96 columns will be broken into sensible chunks, -unless exceeding 96 columns significantly increases readability and does +Statements longer than 80 columns will be broken into sensible chunks, +unless exceeding 80 columns significantly increases readability and does not hide information. Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list. However, never break
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31915 )
Change subject: Revert "Documentation: Our coding style now allows 80 + 2*8 columns in a line" ......................................................................
Patch Set 3: Code-Review+2
-
Julius Werner (Code Review) -
Nico Huber (Code Review)