Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 Clock IC driver ......................................................................
Patch Set 8:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85734/comment/c4f3c16e_ca07d6cc?usp... : PS6, Line 10: ,
`. […]
Done
File src/soc/mediatek/common/include/soc/mt6685.h:
https://review.coreboot.org/c/coreboot/+/85734/comment/b9c74414_3b6b76a9?usp... : PS6, Line 1: SPDX-License-Identifier: GPL-2.0-only
SPDX-License-Identifier: GPL-2. […]
Done
File src/soc/mediatek/common/mt6685.c:
https://review.coreboot.org/c/coreboot/+/85734/comment/a0ee2af6_a8879beb?usp... : PS6, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
SPDX-License-Identifier: GPL-2. […]
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/ea05c530_3e134122?usp... : PS6, Line 72: 0xFFFF
Are you sure this is correct? `pmif_spmi_read` should only read 1 byte of data, so that (when shift […]
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/6e35aff7_3254841a?usp... : PS6, Line 78: key_protect_setting
We should use a different struct other than `mt6685_setting` if only `addr` and `val` are used. […]
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/1194f9af_162d9617?usp... : PS6, Line 92: [MT6685]
Remove "MT6685", as it's already included in the function name.
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/9d33a7fc_deaca66e?usp... : PS6, Line 103: MT6685
Remove "MT6685", as it's already included in the function name.
Done
https://review.coreboot.org/c/coreboot/+/85734/comment/1a9457c8_b80f022b?usp... : PS6, Line 104: 0xFFFF
Same here.
Done
-
Hope Wang (Code Review)